Implement lcm function in keras.ops #21636
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @shashaka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request expands the Keras operations library by adding a new lcm (least common multiple) function. This enhancement provides a fundamental mathematical operation for integer tensors, making Keras more versatile for numerical computations that require LCM, while ensuring broad compatibility across its supported backends.
Highlights
- New
lcmoperation: Introduceskeras.ops.lcmto compute the element-wise least common multiple of two tensor inputs, supporting broadcasting. - Backend Support: The
lcmoperation is implemented and supported across NumPy, TensorFlow, PyTorch, and JAX backends. - OpenVINO Exclusion: The
lcmoperation is explicitly marked as not supported on the OpenVINO backend, with corresponding tests excluded. - Comprehensive Testing: New tests have been added to
keras/src/ops/numpy_test.pyto cover symbolic shapes, static shapes, correctness across various inputs (including broadcasting), and dtype handling for thelcmoperation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces keras.ops.lcm to compute the element-wise least common multiple, with support for NumPy, TensorFlow, PyTorch, and JAX backends. The implementation is well-structured, following the existing patterns for Keras ops, and includes comprehensive tests for correctness, shape inference, and data types. The backend-specific implementations correctly leverage the respective libraries' functionalities. My main feedback is to add a usage example to the lcm function's docstring to align with the repository's style guide.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21636 +/- ##
=======================================
Coverage 82.54% 82.55%
=======================================
Files 571 571
Lines 57584 57634 +50
Branches 8994 8997 +3
=======================================
+ Hits 47531 47577 +46
- Misses 7760 7763 +3
- Partials 2293 2294 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds keras.ops.lcm, which computes the element-wise least common multiple of two tensor inputs (x1 and x2).
Equivalent to applying the integer lcm operation with broadcasting support.
Supported across NumPy, TensorFlow, PyTorch, and JAX backends.
Not supported on OpenVINO.