Skip to content

Fix ConcretizationTypeError in dot_product_attention with traced masks #21853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −0
Open

Fix ConcretizationTypeError in dot_product_attention with traced masks #21853

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc319e2
Disable flash attention for traced masks
Abhinavexists Nov 15, 2025
a6b65a4
Update keras/src/backend/jax/nn.py
Abhinavexists Nov 15, 2025
862c271
Update keras/src/backend/jax/nn.py
Abhinavexists Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions keras/src/backend/jax/nn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,6 +1276,10 @@ def dot_product_attention(
# use flash attention
_can_use_flash_attention(query, key, value, bias, raise_error=True)

# On TPU, traced masks cause ConcretizationTypeError with flash attention.
if is_tpu and mask is not None and isinstance(mask, jax.core.Tracer):
flash_attention = False

# TPU-specific flash attention path
if is_tpu and flash_attention:
# Get sharding parameters from distribution context
Expand Down