Fix timezone for New Zealand#496
Open
icelaglace wants to merge 1 commit intokercre123:mainfrom
Open
Conversation
Australia/Auckland does not exist, return Pacific/Auckland instead.
Contributor
|
I can't check and see if this is the case at the moment but I do have modified versions of the stock ep firmware here which do have dev features open which you can use to check if this is the case on stock as well, try 6085ep/6086ep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Australia/Auckland does not exist on my Vector, return Pacific/Auckland instead.
Reason :
/usr/share/zoneinfo/using WireOS at least, Auckland is inPacificfolder, notAustraliaThis is normal Linux behaviour IMO as it's where it is on every Linux distribution, but I wonder if it's only for WireOS as I don't have access to an unlocked stock firmware.
Leaving this as a PR if that's actually the case on all firmwares then we're good 🔥
Thanks :)