selftests/bpf: Fix count write in testapp_xdp_metadata_copy() #9618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 98857d1 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
1e6c912 to
17f7415
Compare
|
Upstream branch: 6417ca8 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/997033=>bpf-next
branch
from
7eb2939 to
02c1d05
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
17f7415 to
a9f9e99
Compare
|
Upstream branch: e4980fa |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/997033=>bpf-next
branch
from
02c1d05 to
5370312
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
a9f9e99 to
c20f844
Compare
|
Upstream branch: 2a91225 |
Commit 4b30209 ("selftests/xsk: Add tail adjustment tests and support check") added a new global to xsk_xdp_progs.c, but left out the access in the testapp_xdp_metadata_copy() function. Since bpf_map_update_elem() will write to the whole bss section, it gets truncated. Fix by writing to skel_rx->bss->count directly. Fixes: 4b30209 ("selftests/xsk: Add tail adjustment tests and support check") Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/997033=>bpf-next
branch
from
5370312 to
c619b6d
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
c20f844 to
e4e08c1
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=997033 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: Fix count write in testapp_xdp_metadata_copy()
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=997033