Skip to content

Conversation

@webdevbyjoss
Copy link
Contributor

@webdevbyjoss webdevbyjoss commented Mar 2, 2025

Description of this change

Improve the WebView component handling during the dialog dismissal flow, preventing occasional crashes and screen lock.

  1. Improved cleanup process for WebViews
  2. Workaround for the "[ERROR:aw_browser_terminator.cc(154)] Renderer process crash" issue by:
    • Disabling JavaScript execution during cleanup and removing event listeners
    • Adding delays to allow WebView internals to execute properly
  3. README improvements to make the local development easier.

Why is this change being made?

  • Chore (non-functional changes)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested? How can the reviewer verify your testing?

These changes were tested by:

  1. Opening and closing dialogs multiple times to ensure no crashes occur.
  2. Testing the app under stress conditions (rapid opening/closing of dialogs)

Related issues

  • (Jira ticket TBD) Fixes WebView renderer process crash when closing dialogs
  • (Jira ticket TBD) Addresses memory leaks in WebView handling

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have evaluated the security impact of this change, and OWASP Secure Coding Practices have been observed.
  • I have informed stakeholders of my changes.

@webdevbyjoss webdevbyjoss requested a review from Copilot March 14, 2025 03:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@webdevbyjoss webdevbyjoss requested a review from Copilot March 14, 2025 03:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant