Update: modernize dependencies#27
Open
BazanAlexandro wants to merge 20 commits intokevincennis:masterfrom
Open
Update: modernize dependencies#27BazanAlexandro wants to merge 20 commits intokevincennis:masterfrom
BazanAlexandro wants to merge 20 commits intokevincennis:masterfrom
Conversation
Owner
|
Thanks so much for all the work you've put into this. It's a bit hard to review as-is because the change from 2 spaces to 4 made everything part of the diff. Could you maybe back out those changes for now and submit only the stuff that's actually required to upgrade the dependencies? |
Author
Uhh, sorry. Will change spacing part. And try to check if it will be a little clearer to understand the diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to keep the package up to date, following dependencies were updated/changed:
Some of the packages, especially backbone and backbone.marionette required breaking changes, so tried to update accordingly.
I've really tried to rewrite backbone logic in React, but essentially it's too much work, I guess an lot of logic will be rewritten to React.
Also, removed marionette modules in favour of ES6 ones.
So, let me know what you think