This repository was archived by the owner on May 29, 2024. It is now read-only.
Allow non-threadsafe projects to be compatible with --tests-per-worker=1#79
Open
bukzor wants to merge 1 commit intokevlened:masterfrom
Open
Allow non-threadsafe projects to be compatible with --tests-per-worker=1#79bukzor wants to merge 1 commit intokevlened:masterfrom
bukzor wants to merge 1 commit intokevlened:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could instead add a more explicit --nothreading option, if you prefer, but this patch makes pytest-parallel a drop-in replacement for pytest-xdist (if you added -n as an alias for --workers), which is what we're using it as.
Even better would be to have the first "thread" of each process run in the main thread, and send anything marked with pytest.mark.threadunsafe to only main-thread workers. But that's a ton more work.