Added elementType prop to component to override the default H1#32
Open
michaeloryl wants to merge 5 commits intokevoese:developfrom
Open
Added elementType prop to component to override the default H1#32michaeloryl wants to merge 5 commits intokevoese:developfrom
michaeloryl wants to merge 5 commits intokevoese:developfrom
Conversation
Multi loop feature
…raps the text displayed with the typewriter effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now pass in a parameter to change the type of element that wraps the typewriter-effect text. You can pass in a string (such as 'h1' or 'div') or you can pass in a React component. If nothing is passed in, it defaults to 'h1' to maintain backwards compatibility.
Additionally, the element used for the cursor was changed from a DIV to a SPAN, because you can't put DIVs in certain other container elements legally (like H1). Span works fine in this case.
I also fixed some grammar issues, and sorted some of the properties listed in code.