-
Notifications
You must be signed in to change notification settings - Fork 19
Add netbsd build header to process_nix/unix #10
Conversation
On NetBSD we can take advantage of Linux Emulation so we have the procfs mounted and simply use what Linux does. This builds and the tests pass in the scenario. I haven't yet been able to get the tests to pass by copying the process_openbsd.go approach. If/when I do I will do that as a separate branch. References: https://github.com/dressupgeekout/keybase-client/commit/bccaaf3096a575589bb6ee8194008c34fe1f97c8
|
Thanks for putting this PR up. I'm not familiar with netbsd. Is procfs supported by default? Do netbsd users need to install anything special for this to work? And if they don't, what is the effect here, an empty process list result or an error? |
|
It's not enabled by default, but I guess you could say is supported by default. On both my NetBSD systems I've got it enabled.
I'll spin up another NetBSD system that doesn't use it and then see what happens to answer this question. |
|
Well... I'm dumb, but in a good way. Procfs is a standard thing on NetBSD (only been using this OS six years, think I would have known this by now). So on NetBSD amd64 at least (probably other ports as well) this PR allows the keybase command line client to run and build properly (i.e. server launches and forks to the background). Here's what I did, short version:
Slightly longer version:
fwiw: |
|
That comment should really be on the other PR. Specific to go-ps on a fresh NetBSD amd64 install: (Sequences maybe shortened/dumb mistakes removed) |
|
fwiw (will mention here because it fits in with the above) I cross built a NetBSD arm version from my amd64 box, uploaded that to a NetBSD arm box and was able to run keybase client there as well. I.e. could login, |
|
Awesome, thanks for checking it out! |
|
I wonder if we'll need to revisit this for the other BSDs, but we can punt that for now. |
On NetBSD we can take advantage of Linux Emulation so we have the procfs
mounted and simply use what Linux does.
This builds and the tests pass in the scenario.
I haven't yet been able to get the tests to pass by copying the
process_openbsd.go approach. If/when I do I will do that as a separate
branch.
References: https://github.com/dressupgeekout/keybase-client/commit/bccaaf3096a575589bb6ee8194008c34fe1f97c8
References: keybase/client#19061