Skip to content

Conversation

@darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Jan 30, 2025

🍒 pick of #267 to master. Fixes #268

This updates the mssql.Dockerfile version of server:2022 to incorporate MS fix so the site can run on new kernels on CI.

Already deployed on the staging branch.

Test-bot: skip

@darcywong00 darcywong00 added this to the A18S20 milestone Jan 30, 2025
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess LGTM, although I am not excited about making infrastructure changes like this during our transition to beta. Can this wait until B18S2 or B18S3 for merge?

@darcywong00 darcywong00 modified the milestones: A18S20, B18S1 Feb 1, 2025
@darcywong00 darcywong00 modified the milestones: B18S1, B18S2 Feb 15, 2025
@darcywong00 darcywong00 modified the milestones: B18S2, B18S3 Feb 28, 2025
@darcywong00 darcywong00 modified the milestones: B18S3, B18S4 Mar 14, 2025
@darcywong00 darcywong00 modified the milestones: B18S4, B18S5 Mar 29, 2025
@darcywong00 darcywong00 modified the milestones: B18S5, A19S1 Apr 12, 2025
@keyman-server keyman-server modified the milestones: A19S1, A19S2 Apr 26, 2025
@mcdurdin
Copy link
Member

mcdurdin commented May 5, 2025

OK, now that I will be travelling, let's schedule this for merge on 26 or 27 May.

@mcdurdin mcdurdin modified the milestones: A19S2, A19S4 May 5, 2025
@keyman-server keyman-server modified the milestones: A19S4, A19S5 Jun 8, 2025
@keyman-server keyman-server modified the milestones: A19S5, A19S6 Jun 22, 2025
@keyman-server keyman-server modified the milestones: A19S6, A19S7 Jul 6, 2025
@keyman-server keyman-server removed this from the A19S7 milestone Jul 20, 2025
@keyman-server keyman-server added this to the A19S8 milestone Jul 20, 2025
@darcywong00 darcywong00 modified the milestones: A19S8, A19S9 Aug 2, 2025
@darcywong00 darcywong00 modified the milestones: A19S9, A19S10 Aug 16, 2025
@darcywong00 darcywong00 modified the milestones: A19S10, A19S11 Aug 29, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Sep 2, 2025

User Test Results

Test specification and instructions

User tests are not required

@mcdurdin mcdurdin merged commit 184a2c1 into master Sep 2, 2025
4 checks passed
@mcdurdin mcdurdin deleted the cherrypick/unpin-sha branch September 2, 2025 12:00
@github-project-automation github-project-automation bot moved this to Done in Keyman Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug: CI fails when deploying on newer kernels

4 participants