chore: restrict empty search query #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty search query is expensive and should not be permitted, as it returns every record in the keyboard table, rather than a subset. Note: this is a mitigation, as no rate limiting is supported. v2.0 search supports paging, so perhaps we should consider retiring v1.0 search altogether.
darcywong00
reviewed
Apr 3, 2025
| $q = $_REQUEST['q']; | ||
| $q = trim($_REQUEST['q']); | ||
|
|
||
| if($q == '') { |
Member
Author
There was a problem hiding this comment.
Yes, we do for now. That returns 45kb result set and is much quicker to run.
Member
Author
There was a problem hiding this comment.
q=% on the other hand has the same problem as q=. But one step at a time huh?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty search query is expensive and should not be permitted, as it returns every record in the keyboard table, rather than a subset.
Note: this is a mitigation, as no rate limiting is supported. v2.0 search supports paging, so perhaps we should consider retiring v1.0 search altogether.