Skip to content

Conversation

@darcywong00
Copy link
Contributor

End of sprint task

mcdurdin and others added 6 commits April 3, 2025 05:43
An empty search query is expensive and should not be permitted, as it
returns every record in the keyboard table, rather than a subset.

Note: this is a mitigation, as no rate limiting is supported. v2.0
search supports paging, so perhaps we should consider retiring v1.0
search altogether.
Co-authored-by: Darcy Wong <darcy_wong@sil.org>
@darcywong00 darcywong00 added this to the B18S5 milestone Apr 11, 2025
@darcywong00 darcywong00 requested a review from mcdurdin April 11, 2025 03:05
@darcywong00 darcywong00 modified the milestones: B18S5, A19S1 Apr 12, 2025
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@darcywong00 darcywong00 merged commit 97a5ed6 into staging Apr 21, 2025
3 checks passed
@darcywong00 darcywong00 deleted the chore/merge-master-to-staging-b18s5 branch April 21, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants