chore: Merge master to staging for Sprint A19S9 #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test bot has also just been installed, so this serves as a test bot verification also. Relates-to: keymanapp/keyman#559 Test-bot: skip
Test bot has also just been installed, so this serves as a test bot verification also. Relates-to: keymanapp/keyman#559 Test-bot: skip
Co-authored-by: Darcy Wong <darcy_wong@sil.org>
…manapp/api.keyman.com into maint/559-add-labeler
We started to see situations where status checks for new PRs would fail, for example see #290, with hard to parse errors about actual search results mismatching expected results. After digging in, with a lot of logging and debugging, I found that the issue was a race where the test would run before full text indexing had completed. This change delays the completion of the database build until the full text indexing has finished. The full description of my investigation is recorded in #290 for future reference.
Keeping in git log for posterity
fix: wait for full text indexing to complete when building database
maint: add labeler for issues and PRs
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End of sprint task
Test-bot: skip