Skip to content

Conversation

@Milo-Posada
Copy link

No description provided.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@LornaSIL
Copy link
Contributor

Thanks for your pull request @Milo-Posada !
We do have some strict requirements, some of them are required by our build system, and some of them are more stringent for keyboards in the release stream. Since you've submitted this in release I'll assume you want to follow those requirements.

  • The files in the root of shavian_doublekeys all look good.
  • The .kmn file needs changes:
    • Please add the copyright holder. Do not include the year so that doesn't have to be continually updated
    • Please remove the [K_TAB] rule
    • Please change your ALT rules to RALT. This is important to make the keyboard not conflict with applications that have shortcuts to ALT. It also makes it work better with macOS and Linux.
    • After changing the rules to RALT you should regenerate the On-Screen keyboard.
    • My preference is that you actually remove all the rules that produce Latin letters. This is because the keyboard is supposed to support Shavian. We can't associate it with two different scripts. It's much better for users to just switch to another keyboard when they need to type Latin.
  • We already have the InterAlia font in our repo, so you should remove that font from this pull request and in your .kps file reference the one in our repo. This would be the path <Name>..\..\..\shared\fonts\shaw\inter_alia\InterAlia-Regular.ttf</Name> (I did double-check and the version seems to be the same).
  • For keyboards in release: we also require there to be at least minimal documentation for the keyboard. In the welcome.htm file at a minimum you could say "This keyboard comes with an On-Screen keyboard" which can be used to see the keystrokes." However, most welcome.htm files include screenshots of the On-Screen keyboards. You can easily export screenshots from within the On-Screen keyboard tab and click on Export. Choose the type of png and export a single graphic or separate graphics for each layer. Then include those graphics in the welcome file and in the list of files in the .kps.
  • For keyboards in release: we also require a source\help folder with a file called source\help\shavian_doublekeys.php in it. You can read about creating that file here: https://help.keyman.com/developer/keyboards/phphelpfile

I hope you can figure all this out. I suspect you will be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants