feat: Localize keyboard details page 🗺️ #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
approved these changes
Nov 18, 2025
Member
There was a problem hiding this comment.
path should be keyboard-details, not keyboards-details
Contributor
Author
There was a problem hiding this comment.
Since I've got the keyboards/ strings under /_includes/locale/strings/keyboards
what if we nested the folders like:
..../keyboards/
/details/
/share/
/install/
mcdurdin
reviewed
Nov 18, 2025
Comment on lines
129
to
131
| $install_keyboard = _m("install_keyboard"); | ||
| $install_keyboard_button_description = _m("install_keyboard_button_description", | ||
| $h_filename, $platformTitle); |
Contributor
Author
There was a problem hiding this comment.
woof - thanks for 🦆 on getting the boilerplate working.
Co-authored-by: Marc Durdin <marc@durdin.net>
Includes namespace for each file to call localized strings
darcywong00
commented
Nov 20, 2025
| return $str; | ||
| } | ||
| return vsprintf($str, ...$args); | ||
| return vsprintf($str, array(...$args)); |
Contributor
Author
There was a problem hiding this comment.
Needed this for the formatted strings with 2+ parameters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #604 for #384
This continues the Locale.php to localize the keyboard details results.
Note, some of the content comes from other sources (e.g. keyboard details in the keyboards repo)
Test-bot: skip