change: tweak signup form and link to blog subscribe page #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
reviewed
Dec 4, 2025
| #mc_embed_signup_page #num-subscribers span {padding:.5em; border:1px solid #ccc; margin-right:.5em; font-weight:bold;} | ||
|
|
||
| #mc_embed_signup_page #mc-embedded-subscribe-form div.mce_inline_error {display:inline-block; margin:2px 0 1em 0; padding:5px 10px; background-color:rgba(255,255,255,0.85); -webkit-border-radius: 3px; -moz-border-radius: 3px; border-radius: 3px; font-size:14px; font-weight:normal; z-index:1; color:#e85c41;} | ||
| #mc_embed_signup_page #mc-embedded-subscribe-form input.mce_inline_error {border:2px solid #e85c41;} |
Contributor
There was a problem hiding this comment.
Was this all previously from classic-10_7.css?
Would it be cleaner to put into a separate mailchimp.css file?
Member
Author
There was a problem hiding this comment.
We could move to a separate .css, but it's only used in this page, so it's not a big win.
Member
Author
There was a problem hiding this comment.
And yeah, it was previously in that linked .css; I have tweaked it to make it look more keyman.com-ish (e.g. font, color)
Contributor
|
I'm merging this to get it in the end-of-sprint tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test-bot: skip