-
-
Notifications
You must be signed in to change notification settings - Fork 130
fix(developer): remove redundant Name and RTL fields from .kps LexicalModel
#13640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mcdurdin
merged 1 commit into
beta
from
fix/developer/13600-follow-remove-redundant-lm-fields-from-kps
Apr 2, 2025
Merged
fix(developer): remove redundant Name and RTL fields from .kps LexicalModel
#13640
mcdurdin
merged 1 commit into
beta
from
fix/developer/13600-follow-remove-redundant-lm-fields-from-kps
Apr 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alModel` Follows on from the similar changes to `Keyboard` fields in #13600. This deprecates the `RTL` and `Name` fields. `RTL` was never used. `Name` was written but never presented to end users, so effectively irrelevant. `Name` also was present in `File.Description` (already deprecated) for the corresponding model.js _and_ `Info.Name`, so doubly redundant. Also updates the schema documentation to mark the deprecated fields. Relates-to: #13600
User Test ResultsTest specification and instructions Test Artifacts |
darcywong00
approved these changes
Apr 2, 2025
Contributor
darcywong00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Base automatically changed from
fix/developer/13576-13593-remove-redundant-keyboard-fields-from-kps
to
beta
April 2, 2025 22:40
mcdurdin
added a commit
to keymanapp/api.keyman.com
that referenced
this pull request
Apr 2, 2025
Collaborator
|
Changes in this pull request will be available for download in Keyman version 18.0.227-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Follows on from the similar changes to
Keyboardfields in #13600. This deprecates theRTLandNamefields.RTLwas never used.Namewas written but never presented to end users, so effectively irrelevant.Namealso was present inFile.Description(already deprecated) for the corresponding model.js andInfo.Name, so doubly redundant.Also updates the schema documentation to mark the deprecated fields.
Relates-to: #13600
TODO
User Testing
TEST_COMPILE: Load a lexical model project from the lexical models repository. Open the .kps file, make an inconsequential change, save it, and try and build the entire project. Verify that the project builds. Open the .kps file in a text editor, and verify that the field
Package/LexicalModels/LexicalModel/Namehas been removed.TEST_NEW_PROJECT: Create a new lexical model project and verify that it builds correctly