feat(web): add correction source search-space identification 🚂 #14910
+215
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
feat/web/search-space-identifiers
branch
from
887e34f to
5dbdd57
Compare
jahorton
changed the base branch from
refactor/web/multi-space-correction-search
to
refactor/web/simple-search-space-reuse
jahorton
force-pushed
the
refactor/web/simple-search-space-reuse
branch
from
4c2a311 to
12fde6f
Compare
jahorton
force-pushed
the
feat/web/search-space-identifiers
branch
from
11cf559 to
ff8d585
Compare
jahorton
force-pushed
the
feat/web/search-space-identifiers
branch
from
ff8d585 to
e0ff579
Compare
jahorton
force-pushed
the
refactor/web/simple-search-space-reuse
branch
from
bd05992 to
cf96a0f
Compare
jahorton
changed the base branch from
refactor/web/simple-search-space-reuse
to
refactor/web/search-batcher
jahorton
force-pushed
the
feat/web/search-space-identifiers
branch
from
e0ff579 to
d2d5c67
Compare
ermshiperete
approved these changes
Nov 14, 2025
web/src/engine/predictive-text/worker-thread/src/main/correction/distance-modeler.ts
Outdated
Show resolved
Hide resolved
jahorton
force-pushed
the
refactor/web/search-batcher
branch
from
7e5d78c to
907f03c
Compare
When we start supporting more than one "space" for correction-searches, we may need to know which "space" (tokenization) a suggestion arose from. This way, we have a path forward for applying tokenization-dependent behaviors that may be required. Build-bot: skip build:web Test-bot: skip
…rvation transform
jahorton
force-pushed
the
feat/web/search-space-identifiers
branch
from
d2d5c67 to
43f5498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we start supporting more than one "space" for correction-searches, we may need to know which "search space" (underlying that: which tokenization) a suggestion arose from. This will give us a path forward for finding a suggestion's source so that we may apply tokenization-dependent behaviors that may be required.
Build-bot: skip build:web
Test-bot: skip