refactor(web): relocate SearchSpace definition as SearchQuotientSpur, tests to own code file 🚂 #14920
+598
−559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/correction-heuristic-and-thresholding
branch
from
d544b55 to
1df3a35
Compare
jahorton
force-pushed
the
refactor/web/relocate-search-space
branch
from
db32a59 to
be473a1
Compare
SearchSpace itself will become an _interface_ implemented by what is now SearchPath, and another type also implementing it will be introduced in an upcoming PR.
jahorton
force-pushed
the
refactor/web/relocate-search-space
branch
from
f64965a to
54c76c9
Compare
jahorton
changed the title
…o refactor/web/relocate-search-space
…o refactor/web/relocate-search-space
jahorton
force-pushed
the
refactor/web/relocate-search-space
branch
from
2b1136c to
c02de14
Compare
jahorton
changed the title
jahorton
commented
Jan 5, 2026
| * corrections for this ContextToken instance. | ||
| */ | ||
| readonly searchSpace: SearchSpace; | ||
| readonly searchSpace: SearchQuotientSpur; |
Contributor
Author
There was a problem hiding this comment.
TODO: determine a better property name. Long-term, per #15161, this should reflect the SearchQuotientNode (previously, SearchSpace) module handler matching the token.
Perhaps searchGraphModule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To promote better organization of correction-search constructs, this PR relocates the class previously known as
SearchSpaceto its own source file. The lone major actual change is its rename fromSearchSpacetoSearchPath- an upcoming PR will introduce aSearchSpaceinterface (see #14979) implemented by what is nowSearchPath, with another implementing type to come in an upcoming PR - #14949. I'll add more documentation at that point, since that's when the restructuring begins to settle.Build-bot: skip build:web
Test-bot: skip