refactor(web): rename field core to inputProcessor 🎼

[ermshiperete]

The field of KeymanEngineBase that holds the InputProcessor used to be called core. This can be easily confused with Keyman Core, especially now that we're implementing web-core. This change therefore renames the field to inputProcessor.

Test-bot: skip

[keymanapp-test-bot]

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

• Android
  • Keyman for Android apk - build : all tests passed (no artifacts on BuildLevel "build")
  • FirstVoices Keyboards for Android apk - build : all tests passed (no artifacts on BuildLevel "build")
  • FirstVoices Keyboards for Android apk (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • KeyboardHarness apk - build : all tests passed (no artifacts on BuildLevel "build")
  • Keyman for Android apk (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • KMSample1 apk - build : all tests passed (no artifacts on BuildLevel "build")
  • KMSample2 apk - build : all tests passed (no artifacts on BuildLevel "build")
• Developer
  • Keyman Developer - build : all tests passed (no artifacts on BuildLevel "build")
  • Compiler Regression Tests - build : all tests passed (no artifacts on BuildLevel "build")
  • Keyman Developer (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • kmcomp.zip - build : all tests passed (no artifacts on BuildLevel "build")
  • kmcomp.zip (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
• iOS
  • Keyman for iOS (simulator image) - build : all tests passed (no artifacts on BuildLevel "build")
  • FirstVoices Keyboards for iOS (simulator image) - build : all tests passed (no artifacts on BuildLevel "build")
  • FirstVoices Keyboards for iOS (simulator image) (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • Keyman for iOS (simulator image) (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
• Keyboards
  • Test Keyboards - build : all tests passed (no artifacts on BuildLevel "build")
• Web
  • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")

[mcdurdin]

I don't disagree with your assessment, but we do have dependencies on the name core in other modules (first reference only for each file):

• keyman/android/KMEA/app/src/main/assets/android-host.js

  Line 83 in 1265e87

  keyman.core.languageProcessor.on('statechange', onStateChange);

• keyman/developer/src/server/src/site/test.js

  Line 256 in 7c5064a

  keyman.core.contextDevice = targetDevice; // Note: KeymanWeb internal API

• keyman/ios/engine/KMEI/KeymanEngine/resources/Keyman.bundle/Contents/Resources/ios-host.js

  Line 75 in 5b4df8e

  if(!keyman.core.activeKeyboard && !keyman.keyboardRequisitioner.cache.defaultStub) {

• keyman/web/src/test/manual/web/regression-tests/src/test-runner.js

  Lines 277 to 278 in 62ff9e6

  	if(keyman.core) {
  	keyman.core.resetContext();

You should also fixup the unit tests at:

• keyman/web/src/test/auto/headless/engine/main/headless/inputProcessor.tests.js

  Line 34 in dc450cd

  let core = new InputProcessor(device);

This change would need extensive testing across iOS, Android, and Developer web test.

Then, you should also fixup the Engine documentation where the "Keyman Core Module" is something else again:

• keyman/web/docs/engine/reference/core/index.md

  Line 5 in 6c145cb

  The KeymanWeb core module is exposed to the developer as `window.keyman`.

This isn't a comprehensive audit of potential stumbling points. We need to be careful with JS/TS because internals can easily leak, like in this case.

If we do go ahead with this, the rename should be highlighted in release notes because even though it was an undocumented API, we used it ourselves to accomplish things, and other KeymanWeb integrators may well have done the same.

[darcywong00]

Some additional references:

• keyman/core/include/ldml/keyman_core_ldml.ts

  Line 46 in 1ffe205

  // TODO-LDML: namespace com.keyman.core.ldml {

• keyman/web/docs/internal/context-state-management.md

  Line 62 in 1ffe205

  A cache of recent context-state transitions is stored at `keyman.core.contextCache`, with `keyman.core` being an instance of `InputProcessor` ([web/src/engine/main/src/headless/inputProcessor.ts](https://github.com/keymanapp/keyman/blob/master/web/src/engine/main/src/headless/inputProcessor.ts)), the component responsible for linking keystroke processing with predictive-text support and restoration of context-state for multitap-generated keystrokes.

• keyman/web/src/test/manual/web/issue3701/index.html

  Line 57 in 1ffe205

  let newVal = !keyman.core.languageProcessor.mayPredict;

• keyman/web/src/test/manual/web/issue9469/index.html

  Line 58 in 1ffe205

  let newVal = !keyman.core.languageProcessor.mayPredict;

• keyman/web/src/test/manual/web/prediction-ui/index.html

  Line 64 in 1ffe205

  let newVal = !keyman.core.languageProcessor.mayPredict;

• keyman/web/src/tools/testing/bulk_rendering/renderer_core.ts

  Line 116 in 1ffe205

  const keyboard = keyman.core.activeKeyboard;

  
  (I forget if bulk_renderer is still being run)

[ermshiperete]

I should have checked the rest of the repo. Thanks!

Doesn't seem worth to continue at the moment, so I'm closing this PR.