maint: cleanup ci.sh errors and legacy variables #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse_args and setup_colors were called but did not exist. This means that ci.sh has been operating as if it has no command line parameters for a long time, and a check of the calls from TeamCity shows that indeed, the script is never passed parameters. Thus, stripped out all the parameterized code paths that would never be called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_args and setup_colors were called but did not exist. This means that ci.sh has been operating as if it has no command line parameters for a long time, and a check of the calls from TeamCity shows that indeed, the script is never passed parameters. Thus, stripped out all the parameterized code paths that would never be called.
Fixes: #317
See-also: #319