Draft
Conversation
Owner
Author
|
|
Owner
Author
|
|
Owner
Author
|
|
Owner
Author
|
|
kfcripps
force-pushed
the
5312-upstream
branch
2 times, most recently
from
07f490f to
311aaa6
Compare
kfcripps
force-pushed
the
5312-upstream
branch
3 times, most recently
from
ab0238b to
bd2c6c0
Compare
…#4327) * backends/ebpf: Track header start offset in bytes rather than bits. * backends/ebpf: Remove most remaining uses of bits offset var. Uses still remain in ubpf and tc backends. It would be easy to move the variable definition to the uBPFProgram class, however TC uses eBPFProgram directly (without inheritance). ubpf could be changed to use a byte-level header var as was done in eBPF, however it supports bit-level advance() calls. * testdata: Update p4tc golden outputs following offset tracking changes. This patch also sets the executable bit on all .template files. This is done by the TC backend when they are created, however for some reason never made it to the reference outputs, and the checker script doesn't look at permissions.
…4lang#4387) * Small hotfixes to prevent crashes. * Review comments and fixes.
* Avoid possible silent null-deref in Options::usage * Avoid possible silent null-deref in alias.h * Fix null defer in type checking (after type error) * Avoid null pointer deref in convertErrors * Avoid redundant check for null * Make sure diagnostics don't try to dereference null node just to get its source location * Avoid redundant dynamic cast * Fix tautological condition * Avoid closing file with pclose when not preprocessing * Fix "changes" flag initialization
kfcripps
force-pushed
the
5312-upstream
branch
from
3c429f6 to
5c16c62
Compare
Rename parser C file's eBPF section to "p4tc/parse" and control blocks C file's eBPF section to "p4tc/main".
…ostic is used for a diagnostic that can also be a warning.
kfcripps
force-pushed
the
5312-upstream
branch
from
5c16c62 to
9a5414f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Fix warnings by running
ninja -j4 --update: