Update for Node 0.12 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes deprecation warnings with 0.12
Owner
|
@philk Thanks for the pull request. Looks like people have submitted pull requests and filed issues to update toobusy, but these have been ignored. Let me investigate a bit further. I would be interested in seeing how the JS version compares in terms of performance (memory overhead, etc). I will get back to you shortly. |
Owner
|
@philk merged and a new version published to NPM. Updated the documentation and got 100% code coverage, so should be good to go. Let me know if you have any further issues. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using this module to simplify gathering some health metrics (thanks!) but it failed to build on Node 0.12. This just replaces toobusy with toobusy-js. Tests pass and the example returns what's expected so I think it was (shockingly) just that easy.