Skip to content

docs: 2-tier architecture, canonical ownership, fact sync#17

Merged
kiaquila merged 4 commits intomainfrom
claude/silly-margulis-57ff15
Apr 18, 2026
Merged

docs: 2-tier architecture, canonical ownership, fact sync#17
kiaquila merged 4 commits intomainfrom
claude/silly-margulis-57ff15

Conversation

@kiaquila
Copy link
Copy Markdown
Owner

Summary

  • Consolidates docs to 2 entry points (CLAUDE.md + AGENTS.md); constitution.md and docs_pallete_maker/README.md become content/index files, not entry points.
  • Establishes canonical-ownership map for duplicated facts: palette size → project-idea.md; grid columns → frontend-docs.md; review policy → ai-orchestration-protocol.md; Standard Feature Loop → constitution.md; bot-trigger rejection → review-trigger-automation.md; OMC modes → CLAUDE.md.
  • Fact sync against code: palette up to 15 (12 chromatic + 3 achromatic) from harmony.mjs:72-73; grid 11 cols ≥1280px from index.html:221; default review backend codex (switched 2026-04-17); Claude review marked non-operational (dead-code pending cleanup).
  • Removes phantom references to deleted macos-local-runners.md (AGENTS.md rule 4, constitution.md).
  • Adds orientability headers (> Audience: ... | Prereq: ... | Next: ...) to all 6 devops docs.
  • Extracts non-adopted Tier 2/3 review-trigger design into new docs_pallete_maker/adr/0001-review-trigger-design.md; shrinks review-trigger-automation.md to active Tier 1 only.
  • Adds 2 directives to CLAUDE.md (from Karpathy CLAUDE.md delta, critic-validated): no single-use abstractions; inline step+verify plan for multi-step tasks without a spec.

Net -70 lines; duplicated blocks consolidated to single canonical homes with cross-references.

Test plan

  • pnpm run preflight — feature-memory gate + baseline + html-validate + build + format + 59/59 tests green
  • baseline-checks, guard, AI Review green on PR
  • Codex review on latest push (posted via human-authored @codex review)
  • Vercel preview builds cleanly (docs-only change)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kiaquila
Copy link
Copy Markdown
Owner Author

@codex review

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pallete-maker Ready Ready Preview, Comment Apr 18, 2026 5:58pm

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c3da00030

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +33 to +35
- After a new push, a human must post the native trigger comment
(`@codex review`, `/gemini review`, or `@claude review once`), or run
`pnpm run review:switch -- --to <agent>`. Bot-posted triggers are rejected
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Require human trigger for initial Codex PR reviews

This wording implies manual triggers are only needed after subsequent pushes, but with codex as the selected reviewer the first PR review is not automatic: .github/workflows/ai-review.yml sets trigger_mode="skip" on pull_request events, and in skip mode scripts/ai-review-gate.mjs polls for an existing Codex review instead of posting @codex review. On a newly opened PR, that can leave AI Review waiting until timeout unless a human posts the trigger immediately, so the workflow doc should explicitly include the initial PR review case.

Useful? React with 👍 / 👎.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kiaquila
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f216d120a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


- implementation: `claude`
- review: `gemini`
- review: `codex` (switched from `gemini` on 2026-04-17)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reconcile codex default claim with automation fallback

This line now declares codex as the repository default reviewer, but the automation still falls back to gemini when AI_REVIEW_AGENT is unset (.github/workflows/ai-review.yml sets selected="gemini" when the variable is empty, and .github/workflows/ai-command-policy.yml uses defaults.review = "gemini"). In environments where the variable is missing (for example a fresh fork or accidental variable deletion), operators following this doc will trigger @codex review while the AI Review gate is actually polling Gemini, which can lead to avoidable timeout/failure behavior.

Useful? React with 👍 / 👎.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kiaquila
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kiaquila
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kiaquila kiaquila merged commit e98205c into main Apr 18, 2026
6 checks passed
@kiaquila kiaquila deleted the claude/silly-margulis-57ff15 branch April 18, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant