Fixed chat message now showing the correct required number of votes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidfearless
reviewed
Sep 24, 2020
| g_hEnhancedMenu.AddItem("Alphabetic", "Alphabetic"); | ||
|
|
||
| for( int i = 0; i <= 10; ++i ) | ||
| for(int i = GetConVarInt(g_cvMinTier); i <= GetConVarInt(g_cvMaxTier); ++i) |
Owner
There was a problem hiding this comment.
Replace all GetConvarInt with convar.IntValue
|
|
||
| void OpenNominateMenuTier(int client, int tier) | ||
| { | ||
| DisplayMenu(g_aTierMenus.Get(tier-GetConVarInt(g_cvMinTier)), client, MENU_TIME_FOREVER); |
Owner
There was a problem hiding this comment.
user the Display method instead of function
| else if (action == MenuAction_End) | ||
| { | ||
| if (menu != g_hNominateMenu && menu != INVALID_HANDLE) | ||
| if (menu != g_hNominateMenu && menu != INVALID_HANDLE && FindValueInArray(g_aTierMenus, menu) == -1) |
|
|
||
| g_cvMinTier = CreateConVar("smc_min_tier", "0", "The minimum tier to show on the enhanced menu", _, true, 0.0, true, 10.0); | ||
| g_cvMaxTier = CreateConVar("smc_max_tier", "10", "The maximum tier to show on the enhanced menu", _, true, 0.0, true, 10.0); | ||
|
|
Owner
There was a problem hiding this comment.
Should probably add a sanity check so that people don't put a max of 5 and a min of 10
Update shavit-mapchooser.sp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.