Open
Conversation
killergerbah
requested changes
Jun 14, 2025
Owner
killergerbah
left a comment
killergerbah
left a comment
There was a problem hiding this comment.
Thanks for contributing!
This is close, but a new setting is not necessary to store the selected preset. Please use useState instead.
common/components/SettingsForm.tsx
Outdated
| import NoteTypeTutorialBubble from './NoteTypeTutorialBubble'; | ||
|
|
||
| const regexPresetsList = [ | ||
| { name: 'No preset', regex: '' }, |
Owner
There was a problem hiding this comment.
These strings need to be localizable.
Author
|
Added the possibility to localize and changed the logic to use state instead of having a new setting. |
killergerbah
requested changes
Jun 23, 2025
| onChange={(event) => { | ||
| handleSettingChanged('subtitleRegexFilter', event.target.value); | ||
| if (selectedRegexPresetName !== regexPresetsList[0].name) { | ||
| setSelectedRegexPresetName(regexPresetsList[0].name); |
Owner
There was a problem hiding this comment.
It's risky to update state from inside the render function. You should consider using useEffect instead.
Also, ideally if the user types in one of the presets manually the correct one gets selected. This code is selecting the first preset no matter what.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In regard to #237
Localization should probably be added for each preset name don't know how to do.
Support could be added for the (.)\n+(?!-)(.) indicated in the guide in order to change the "regex filter text replacement field" when this regex is selected.
Additional features:
Maybe support for multiples custom preset made by the user?
Note: First pull request
If anything is wrong feel free to explain