This repository was archived by the owner on May 14, 2021. It is now read-only.
Chang blockchain version, add kin ecosystem account status #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doodyparizada
suggested changes
Mar 25, 2019
Contributor
doodyparizada
left a comment
doodyparizada
left a comment
There was a problem hiding this comment.
some changes and questions
| * `migrated` - Account was migrated and burned | ||
| type: string | ||
| enum: [pending, migrate, migrated] |
Contributor
There was a problem hiding this comment.
i would use wallet instead of account to keep it consistent with the rest of our code/ apis
Contributor
There was a problem hiding this comment.
It's nice to have pending and migrated, but from client POV, it's the same > i.e. don't do anything.
Do you anticipate the client having something to do with the extra state?
openapi.yaml
Outdated
| schema: | ||
| type: object | ||
| required: | ||
| - status |
Contributor
There was a problem hiding this comment.
but in the url it's status
openapi.yaml
Outdated
| version: | ||
| type: string | ||
|
|
||
| '/account/kin2/{account_address}/status': |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.