privacy: mask phone numbers by default and add --reveal override#7
Open
vincentayorinde wants to merge 1 commit intokinghacker0:mainfrom
Open
privacy: mask phone numbers by default and add --reveal override#7vincentayorinde wants to merge 1 commit intokinghacker0:mainfrom
vincentayorinde wants to merge 1 commit intokinghacker0:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
Summary
This change masks phone numbers by default in terminal output and saved filenames, and adds a
--revealflag for cases where an authorized investigator explicitly needs the full value.Why
The tool currently exposes full phone numbers in terminal output and local image filenames. That increases the chance of leaking personal data through screenshots, shell history, or shared files.
What changed
--revealflag to show the full phone number only when explicitly requestedScope
Behavior
--reveal: full number in output and filenamesTesting
--revealand confirmed full numbers appear in output and filenames