Skip to content

Read content file outside of eval block#47

Open
atoomic wants to merge 1 commit intokingpong:developfrom
atoomic:spec_helper-read-earlier
Open

Read content file outside of eval block#47
atoomic wants to merge 1 commit intokingpong:developfrom
atoomic:spec_helper-read-earlier

Conversation

@atoomic
Copy link
Copy Markdown

@atoomic atoomic commented Oct 30, 2018

spec_helper is sneaking in some content
from a file to a namespace.

But it's not required to read the file
inside the quoted eval.

Reading it earlier provides the advantage
of building the OP tree for it, so
we can use Test::Mockfile without impacting
this test module.

It also reduces the length of the string eval
and optimize it and make it easier to maintain
at the same time.

spec_helper is sneaking in some content
from a file to a namespace.

But it's not required to read the file
inside the quoted eval.

Reading it earlier provides the advantage
of building the OP tree for it, so
we can use Test::Mockfile without impacting
this test module.

It also reduces the length of the string eval
and optimize it and make it easier to maintain
at the same time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant