Read content file outside of eval block#47
Open
atoomic wants to merge 1 commit intokingpong:developfrom
Open
Conversation
spec_helper is sneaking in some content from a file to a namespace. But it's not required to read the file inside the quoted eval. Reading it earlier provides the advantage of building the OP tree for it, so we can use Test::Mockfile without impacting this test module. It also reduces the length of the string eval and optimize it and make it easier to maintain at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec_helper is sneaking in some content
from a file to a namespace.
But it's not required to read the file
inside the quoted eval.
Reading it earlier provides the advantage
of building the OP tree for it, so
we can use Test::Mockfile without impacting
this test module.
It also reduces the length of the string eval
and optimize it and make it easier to maintain
at the same time.