Conversation
|
Hi, Thank you for providing this information. Before I am merging this, could you make some adjustments to the PR?
|
Thanks for the feedback |
|
Thanks for improving the documentation so far.
I would prefer Offset / Size / Description tables. This is important for consistency with the rest of the documentation. If a value always has a specific value, such as a magic number, this value can be mentioned in the description column. The description column should be clear enough to understand which values can be found in a field. While it can be good to provide examples, a 'value' column is not the best way to do this in my opinion. It would be better if we could provide complete example files for each format (although we would have to be careful not to infringe any copyright with that).
Interesting. The reason that I asked for this, is that all resources that I can find (wikipedia, reddit, gbatemp, etc.) refer to the game as Xenoblade Chronicles 2. Therefore, I believe that referring to the game by its full name would cause the least amount of confusion. If I type XB2 into Google, I do not get any results related to Xenoblade, while XC2 and XBC2 give much better results. If everyone writes XC, it would make sense if we did the same. |
|
I'll write in this format then : Ok, i made the change, it's true that can improve the referencement too. |
|
I guess that for magic numbers that would work, though for consistency it would be best to describe it as a magic number, and then its value in ASCII text. For example, see here: https://nintendo-formats.com/libs/aal/barslist.html I don't really see the point of adding the |
|
(I don't see the change btw) |
|
(I doesn't push yet) |
|
I think write Magic number each time is a lost of space What can i put instead of |
|
Nvm, know the size of a data is enough, i'll delete the ?? ?? ?? ?? and that will be good |
|
Yeah, the size is enough. I'll probably merge the PR this weekend and make some remaining formatting changes myself. Thanks again for the contribution. |
No description provided.