Conversation
rascasoft
left a comment
There was a problem hiding this comment.
I've added some comments, the main directory should be Academy and not AI, but it's something we can modify later on on the review.
There was a problem hiding this comment.
This .gitignore is quite nightmarish... hard to maintain and prone to errors: it should be developer responsibility to exclude files that are not part of the repo, instead of having any kind of exclusion here...
There was a problem hiding this comment.
this is the standard suggested by GH. It covers every possible dependency that should not be pushed. Check Here
There was a problem hiding this comment.
I still find it error prone and very very far from being long term maintainable, mostly because this one is not a Python only repository, but mainly a markdown one.
In any case, no big deal, it can stay as it is, but a so complex template needs to be maintained and kept up-to-date.
rascasoft
left a comment
There was a problem hiding this comment.
I've added the result of my tests.
| "\n", | ||
| " print(f\"Experiment finished. Registered accuracy: {accuracy:.2f}\")" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
While trying to reproduce this on a standard Debian 12, within a Python Virtual Environment with all the requirements installed, I'm getting this:
Traceback (most recent call last):
File "/home/rasca/Labs/venvs/aisetup/mlflow.py", line 3, in <module>
import mlflow
File "/home/rasca/Labs/venvs/aisetup/mlflow.py", line 4, in <module>
import mlflow.sklearn
ModuleNotFoundError: No module named 'mlflow.sklearn'; 'mlflow' is not a package
Maybe it depends on the specific package versions used while writing the lab, so having a requirements.txt would help, but maybe it depends on something else.
Since Python venv should prevent these kind of errors, something needs to be changed/integrated here.
There was a problem hiding this comment.
@rndg just to confirm that I've tried again from scratch, using exactly the steps mentioned in the doc and the result is still the mentioned error.
Since the AI stuff is composed by workshop labs, let's put it under Workshops folder. Signed-off-by: Raoul Scarazzini <rasca@mmul.it>
No description provided.