Interview pieter improved

app/build.gradle

@@ -24,4 +24,6 @@ dependencies {
     compile 'com.android.support:appcompat-v7:22.2.0'
     compile 'com.android.support:design:22.2.0'
     compile 'com.android.support:recyclerview-v7:22.2.0'
+    compile 'com.github.bumptech.glide:glide:3.6.0'
+    compile 'com.android.support:support-v4:22.2.0'
 }

app/src/main/AndroidManifest.xml

@@ -2,6 +2,8 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="android.coding.interview.makeitawesome" >
 
+    <uses-permission android:name="android.permission.INTERNET" />
+
     <application
         android:allowBackup="true"
         android:icon="@mipmap/ic_launcher"
@@ -16,6 +18,7 @@
                 <category android:name="android.intent.category.LAUNCHER" />
             </intent-filter>
         </activity>
+        <activity android:name=".Picture"/>
     </application>
 
 </manifest>

app/src/main/java/android/coding/interview/makeitawesome/Picture.java

@@ -0,0 +1,31 @@
+package android.coding.interview.makeitawesome;
+
+import android.app.Activity;
+import android.content.Intent;
+import android.os.Bundle;
+import android.widget.ImageView;
+
+import com.bumptech.glide.Glide;
+
+/**
+ * Created by pinghelram on 27/07/15.
+ */
+public class Picture extends Activity {
+    ImageView myImage;
+    public static final String IMAGEURL = "image_url";
+    @Override
+    protected void onCreate(Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);
+        setContentView(R.layout.activity_image);
+        myImage = (ImageView) findViewById(R.id.iv_image);
+
+        Intent myIntent = getIntent();
+        String url = myIntent.getStringExtra(IMAGEURL);
+
+        Glide.with(this).load(url).into(myImage);
+    }
+
+
+
+
+}

app/src/main/java/android/coding/interview/makeitawesome/adapter/PhotosAdapter.java

@@ -1,23 +1,49 @@
 package android.coding.interview.makeitawesome.adapter;
 
 import android.coding.interview.makeitawesome.R;
+import android.coding.interview.makeitawesome.data.ImageData;
+import android.content.Context;
+import android.media.Image;
 import android.support.v7.widget.RecyclerView;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
+import android.widget.ImageView;
 import android.widget.TextView;
 
+import com.bumptech.glide.Glide;
+
+import org.w3c.dom.Text;
+
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 
 /**
  * adapter keeping data for list of photos
  */
 public class PhotosAdapter extends RecyclerView.Adapter<PhotosAdapter.ViewHolder> {
-    
+
     // TODO this is a dummy data that you have to replace. You probably need List of some objects representing pictures
     // rather than just strings
-    private List<String> mData = Arrays.asList("dummy 1", "dummy 2", "dummy 3", "dummy 4", "etc");
+    //private List<String> mData = Arrays.asList("dummy 1", "dummy 2", "dummy 3", "dummy 4", "etc");
+    private List<ImageData> mData;
+    private Context context;
+    private ClickListener clickListener;
+
+    public PhotosAdapter(ArrayList<ImageData> mData, Context context){
+        this.mData = mData;
+        this.context = context;
+    }
+
+    public void setClickListener(ClickListener clickListener){
+        this.clickListener = clickListener;
+    }
+
+    public void insertmData(ImageData mImage, int position){
+        mData.add(position, mImage);
+        notifyItemInserted(position);
+    }
 
     @Override
     public ViewHolder onCreateViewHolder(ViewGroup parent, int i) {
@@ -27,19 +53,45 @@ public ViewHolder onCreateViewHolder(ViewGroup parent, int i) {
 
     @Override
     public void onBindViewHolder(ViewHolder holder, int i) {
-        holder.mText.setText(mData.get(i));
+        //holder.mText.setText(mData.get(i));
+        holder.getImageTitle().setText(mData.get(i).getTitle());
+        //holder.getTv_name_search().setImageResource(R.drawable.abc_ab_share_pack_mtrl_alpha);
+        Glide.with(context).load(mData.get(i).getThumbnailUrl()).into(holder.getIv_image());
     }
 
     @Override
     public int getItemCount() {
         return mData.size();
     }
 
-    public static class ViewHolder extends RecyclerView.ViewHolder {
-        final TextView mText;
+    public class ViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener {
+        private final TextView mTitle;
+        private final ImageView mImageView;
+
         public ViewHolder(View itemView) {
             super(itemView);
-            mText = (TextView) itemView;
+            mTitle = (TextView) itemView.findViewById(R.id.tv_image_title);
+            mImageView = (ImageView) itemView.findViewById(R.id.iv_image);
+            itemView.setOnClickListener(this);
+        }
+
+        public TextView getImageTitle() {
+            return mTitle;
+        }
+
+        public ImageView getIv_image() {
+            return mImageView;
         }
+
+        @Override
+        public void onClick(View v) {
+            if (clickListener!= null){
+                clickListener.itemClicked(v, getAdapterPosition());
+            }
+        }
+    }
+
+    public interface ClickListener {
+        void itemClicked(View view, int position);
     }
 }

app/src/main/java/android/coding/interview/makeitawesome/data/ImageData.java

@@ -0,0 +1,32 @@
+package android.coding.interview.makeitawesome.data;
+
+/**
+ * Created by pinghelram on 27/07/15.
+ */
+public class ImageData {
+    String title, url, thumbnailUrl;
+
+    public String getTitle() {
+        return title;
+    }
+
+    public void setTitle(String title) {
+        this.title = title;
+    }
+
+    public String getUrl() {
+        return url;
+    }
+
+    public void setUrl(String url) {
+        this.url = url;
+    }
+
+    public String getThumbnailUrl() {
+        return thumbnailUrl;
+    }
+
+    public void setThumbnailUrl(String thumbnailUrl) {
+        this.thumbnailUrl = thumbnailUrl;
+    }
+}

app/src/main/java/android/coding/interview/makeitawesome/fragment/PicturesFragment.java

@@ -1,37 +1,149 @@
 package android.coding.interview.makeitawesome.fragment;
 
+import android.app.ProgressDialog;
+import android.coding.interview.makeitawesome.Picture;
 import android.coding.interview.makeitawesome.R;
 import android.coding.interview.makeitawesome.adapter.PhotosAdapter;
+import android.coding.interview.makeitawesome.data.ImageData;
+import android.coding.interview.makeitawesome.utils.DividerItemDecoration;
+import android.coding.interview.makeitawesome.utils.JSONResponseHandler;
+import android.content.Intent;
+import android.net.http.AndroidHttpClient;
+import android.os.AsyncTask;
 import android.os.Bundle;
 import android.support.annotation.Nullable;
 import android.support.v4.app.Fragment;
 import android.support.v7.widget.LinearLayoutManager;
 import android.support.v7.widget.RecyclerView;
+import android.util.Log;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 
+import org.apache.http.client.ClientProtocolException;
+import org.apache.http.client.methods.HttpGet;
+
+import java.io.IOException;
+import java.util.ArrayList;
+
 /**
  * This is Your TASK:<br>
  * This is a fragment where you need to show list of pictures and details fetched from API<br>
  * Most of skeleton for showing UI is implemented. You need to take care of getting the data from server, updating adapter and displaying results
  */
-public class PicturesFragment extends Fragment {
-
+public class PicturesFragment extends Fragment implements PhotosAdapter.ClickListener{
+    private static final String TAG = "PicturesFragment";
+    private final static String URL = "http://jsonplaceholder.typicode.com/photos/";
+    private PhotosAdapter mPhotosAdapter;
+    protected RecyclerView mRecyclerView;
+    private ArrayList<ImageData> mData = new ArrayList<>();
+    private AsyncTask<Void, Void, ArrayList<ImageData>> httpGetTask;
+    private ProgressDialog dialog;
     public static Fragment newInstance() {
         return new PicturesFragment();
     }
 
     @Nullable
     @Override
     public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
-        RecyclerView rv = (RecyclerView) inflater.inflate(R.layout.pictures_list_fragment, container, false);
-        setupRecyclerView(rv);
-        return rv;
+        mPhotosAdapter = new PhotosAdapter(mData, getActivity());
+
+        httpGetTask = new HttpGetTask().execute(); //start background task
+
+        mRecyclerView = (RecyclerView) inflater.inflate(R.layout.pictures_list_fragment, container, false);
+        setupRecyclerView(mRecyclerView);
+        return mRecyclerView;
+    }
+
+    @Override
+    public void onPause() {
+        super.onPause();
+        if (dialog != null){
+            dialog.dismiss();
+        }
+        httpGetTask.cancel(true);
     }
 
     private void setupRecyclerView(RecyclerView recyclerView) {
+        mRecyclerView.addItemDecoration(new DividerItemDecoration(recyclerView.getContext(), DividerItemDecoration.VERTICAL_LIST));
+        mRecyclerView.setAdapter(mPhotosAdapter);
+        mPhotosAdapter.setClickListener(this);
         recyclerView.setLayoutManager(new LinearLayoutManager(recyclerView.getContext()));
-        recyclerView.setAdapter(new PhotosAdapter());
+    }
+
+    @Override
+    public void itemClicked(View view, int position) {
+        Intent intent = new Intent(getActivity(), Picture.class);
+        String url = mData.get(position).getUrl();
+
+        intent.putExtra(Picture.IMAGEURL, url);
+        startActivity(intent);
+    }
+
+    /**
+     * download the data
+     */
+    private class HttpGetTask extends AsyncTask<Void, Void, ArrayList<ImageData>> {
+        AndroidHttpClient mClient = AndroidHttpClient.newInstance("");
+
+
+        @Override
+        protected void onPreExecute() {
+            super.onPreExecute();
+            dialog = new ProgressDialog(getActivity());
+            dialog.setTitle(getString(R.string.loading));
+            dialog.setCancelable(false);
+            dialog.show();
+        }
+
+        @Override
+        protected ArrayList<ImageData> doInBackground(Void... unused) {
+            Log.v(TAG, "doInBackground");
+
+            HttpGet request = new HttpGet(URL);
+            JSONResponseHandler searchresponseHandler = new JSONResponseHandler();
+
+            try {
+                return mClient.execute(request, searchresponseHandler);
+            } catch (ClientProtocolException exception) {
+                exception.printStackTrace();
+            } catch (IOException ioexception) {
+                ioexception.printStackTrace();
+            } finally {
+                if (mClient != null) mClient.close();
+            }
+            return null;
+        }
+
+        @Override
+        protected void onPostExecute(ArrayList<ImageData> result) {
+            Log.v(TAG, "onPostExecute");
+            if (!isCancelled()){
+                dialog.dismiss();
+                ArrayList<ImageData> searchResults = new ArrayList<>();
+
+                if (mClient != null && result != null) {
+                    Log.v(TAG, "search complete");
+                /*for (Map.Entry<String, ImageData> mLibraryItem : result.getphotos().entrySet()) {
+                    searchResults.add(mLibraryItem.getValue());
+                }*/
+                    //for (ImageData data : )
+                    for (ImageData mData : result){
+                        searchResults.add(mData);
+                    }
+                }
+                if ((result == null || result.size() == 0)) {
+                    //todo: if there's no results show no results found
+                    //tv_no_results.setVisibility(View.VISIBLE);
+                } else {
+                    //tv_no_results.setVisibility(View.GONE);
+                    int counter = 0;
+                    for (ImageData imageData: searchResults) {
+                        mPhotosAdapter.insertmData(imageData, counter);
+                        counter++;
+                    }
+                }
+            }
+        }
     }
 }