カートページに自動的にリダイレクトする #135
Merged
カートページに自動的にリダイレクトする #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimurash
reviewed
Nov 14, 2024
frontend/app/routes/home/route.tsx
Outdated
| if (navigation.state === 'idle') { | ||
| if (userId) { | ||
| if (!!userData) { | ||
| // CookieにユーザIDが存在する |
frontend/app/routes/home/route.tsx
Outdated
Comment on lines
108
to
109
| // 状態変数にユーザ情報が保存されていない | ||
| // ユーザ情報を取得するAPIを呼び出す |
| interface SessionData { | ||
| userId: string; | ||
| user: User; | ||
| sessionToken: string; |
Member
There was a problem hiding this comment.
userの中にsessionTokenも含まれてるからsessionTokenは消しておこう
Member
|
この会話が解決してからApproveを出します |
Contributor
Author
チェックよろしく |
kimurash
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
確認した方法
pnpm run devで確認スクリーンショット
2024-11-14.13.51.26.mov
2024-11-14.13.53.08.mov
自動生成したコード