蔵書一覧ページのテストを書いた #140
Merged
蔵書一覧ページのテストを書いた #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kosei805
approved these changes
Nov 17, 2024
Contributor
Kosei805
left a comment
Kosei805
left a comment
There was a problem hiding this comment.
問題なしです。
フロントエンドのactionのとこは参考になるからありがたい。
ちょっと俺の書き方は汚い気はしてました(汗)
| url = | ||
| initial === true ? `${url}?title=${title}` : `${url}&title=${title}`; | ||
| initial = false; | ||
| params.append('title', title); |
Contributor
There was a problem hiding this comment.
書き方の簡略化を知れるのはありがたいけど、このコードが動くかどうか確認した？
| {children} | ||
| </MantineProvider> | ||
| {children} | ||
| </QueryClientProvider> |
Contributor
There was a problem hiding this comment.
MantineTestProviderってテスト以外でも囲われてるの？
Member
Author
There was a problem hiding this comment.
テスト用のコンポーネントだからテスト以外では使用されない
| expect(limitSelect).toHaveValue('10'); | ||
|
|
||
| // FIXME: 5が選択された後なぜかすぐ10が選択される | ||
| await user.selectOptions(limitSelect, '5'); |
Contributor
There was a problem hiding this comment.
ここってテストでOK通るの？
コメントアウトしなくて問題なし？
Member
Author
There was a problem hiding this comment.
UIを操作するだけで何かをチェックする訳ではないから，コメントアウトしなくても大丈夫
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
確認した方法
自動生成したコード
なし