マイページの実装 #143
Merged
マイページの実装 #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimurash
reviewed
Nov 17, 2024
Comment on lines
25
to
27
| <Button fz="xs" color="blue" onClick={handleReturnButtonClick}> | ||
| 返却する | ||
| </Button> |
Member
There was a problem hiding this comment.
「借りる」ボタンが青だから「返却する」ボタンは青とは対照的な色を使った方がいいと思う
Comment on lines
14
to
15
| <Text size={rem(50)}>{name}</Text> | ||
| <Text>{email}</Text> |
Contributor
Author
There was a problem hiding this comment.
プロフィール表示コンポーネント調整の時についでに直してくれい
Comment on lines
147
to
158
| const handlePaginationChange = (newPage: number) => { | ||
| let url = '/home/me'; | ||
| let initial = true; | ||
| if (limit) { | ||
| url = | ||
| initial === true ? `${url}?limit=${limit}` : `${url}&limit=${limit}`; | ||
| initial = false; | ||
| } | ||
| url = | ||
| initial === true ? `${url}?page=${newPage}` : `${url}&page=${newPage}`; | ||
| navigate(url); | ||
| }; |
frontend/app/stores/loanAtom.ts
Outdated
| @@ -0,0 +1,9 @@ | |||
| import { atom } from 'jotai'; | |||
| import { CartProps } from './cartAtom'; | |||
| import { atomWithStorage, createJSONStorage } from 'jotai/utils'; | |||
kimurash
reviewed
Nov 17, 2024
| const isSelected = (element: CartProps) => element.id === id; | ||
|
|
||
| // 該当する本のvolumeを変更する | ||
| const handleChangeVolume = (id: number, value: number) => { |
Member
There was a problem hiding this comment.
僕だったら handleVolumeChange にするかな
| }), | ||
| ); | ||
| const target = selectedCartBook.find(isSelected); | ||
| // volumeを選択されていた本がすでに選択されている場合 |
Comment on lines
+42
to
+50
| if (element.id === id) { | ||
| return { | ||
| id: element.id, | ||
| stock: element.stock, | ||
| thumbnail: element.thumbnail, | ||
| volume: value, | ||
| }; | ||
| } | ||
| return element; |
Contributor
Author
There was a problem hiding this comment.
これは、elementがvolumeが選択された本やったら、volumeを更新して、それ以外なら、elementをそのままにするって処理です。これをmapで繰り返して、配列を更新してる
| </Stack> | ||
| </Dialog> | ||
| ); | ||
| return <div>CartSelectedDialog</div>; |
| const isSelected = (element: CartProps) => element.id === id; | ||
|
|
||
| // 該当する本のvolumeを変更する | ||
| const handleChangeVolume = (id: number, value: number) => { |
Member
There was a problem hiding this comment.
僕だったら handleVolumeChange にするかな
| // 操作する貸出履歴のvolumesを管理するAtom | ||
| export const displayLoanAtom = atom<CartProps[]>([]); |
Contributor
Author
There was a problem hiding this comment.
volumeを操作するデータが欲しいからやね。
チェックボックスにチェックが入ってないデータもvolumeを変えたいから、selected...とは別にデータが必要だった感じ。
Member
|
スクリーンショットありがとう |
kimurash
reviewed
Nov 18, 2024
| session.flash('success', 'ログインに成功しました'); | ||
|
|
||
| return redirect('/home/mypage', { | ||
| return redirect('/home/me', { |
Member
There was a problem hiding this comment.
ここを書き換えるとログインページのテストが落ちると思う
テストコードも修正しておこう
Member
|
プロフィールの部分を変更した 
|
kimurash
approved these changes
Nov 19, 2024
Contributor
Author
|
ユーザーデータのコンポーネント |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
確認した方法
pnpm run devで確かめたスクリーンショット
自動生成したコード