ユーザー作成ページの実装 #148
Merged
ユーザー作成ページの実装 #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimurash
reviewed
Nov 18, 2024
Comment on lines
-28
to
+26
| <LoginSubmitButton isPending={isPending} /> | ||
| <LoginSubmitButton /> |
Contributor
Author
There was a problem hiding this comment.
これはクライアント側でログインのフック動かしてた時にそのフックを使った通信が通信中かどうかみるものやからactionの通信には反応せんはず
それにactionの通信はオーバーレイかかるようにしたしね
Member
There was a problem hiding this comment.
作成するユーザは1人だから user-create/UserCreateComponent.tsx の方がいいと思った
| validate: { | ||
| name: (value) => { | ||
| if (value.length < 1) { | ||
| return '名前は必須です'; |
frontend/app/utils/password.ts
Outdated
| @@ -0,0 +1,11 @@ | |||
| export const passwordGen = () => { | |||
| let password = ''; | |||
| const passwordCheck = (element: string) => | |||
Contributor
Author
There was a problem hiding this comment.
なんと言うか関数というよりフラグのような認識で作ってたからミスったわ
描き直します
kimurash
reviewed
Nov 19, 2024
Comment on lines
31
to
32
| successNotification('パスワードをコピーしました'); | ||
| copy(); |
Comment on lines
+19
to
+25
| <Tooltip | ||
| label={ | ||
| copied ? 'パスワードをコピーしました' : 'パスワードをコピーする' | ||
| } | ||
| withArrow | ||
| position="right" | ||
| > |
kimurash
approved these changes
Nov 19, 2024
| } | ||
| }; | ||
|
|
||
| const UserAddPage = () => { |
Comment on lines
11
to
17
| return ( | ||
| <Button | ||
| disabled | ||
| leftSection={<PasswordValidProgress counts={counts} />} | ||
| >{`パスワードの有効時間：${counts}秒`}</Button> | ||
| ); | ||
| }; |
Member
There was a problem hiding this comment.
Suggested change
| return ( | |
| <Button | |
| disabled | |
| leftSection={<PasswordValidProgress counts={counts} />} | |
| >{`パスワードの有効時間：${counts}秒`}</Button> | |
| ); | |
| }; | |
| const fmtedCounts = counts.toString().padStart(2, ' '); | |
| return ( | |
| <Button | |
| disabled | |
| leftSection={<PasswordValidProgress counts={counts} />} | |
| >{`パスワードの有効時間：${fmtedCounts}秒`}</Button> | |
| ); |
frontend/app/utils/password.ts
Outdated
| @@ -0,0 +1,11 @@ | |||
| export const passwordGen = () => { | |||
| const handlePasswordGenButtonClick = () => { | ||
| const password = passwordGen(); | ||
| clipborad.copy(password); | ||
| // カウントダウンを正常に動かすために、29秒に設定 |
Member
There was a problem hiding this comment.
「コールバック関数の実行時間を考慮して」の方が分かりやすいと思った
kimurash
reviewed
Nov 19, 2024
| setCounts(counts - 1); | ||
| } | ||
| }, 1000); | ||
| return () => clearInterval(countDown); |
Member
There was a problem hiding this comment.
ページが閉じられた時に実行されることをコメントで書いておきたい
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
確認した方法
pnpm iでアップデートpnpm run devで実行したスクリーンショット
自動生成したコード