ユーザー情報編集ページの実装 #150
Merged
ユーザー情報編集ページの実装 #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimurash
approved these changes
Nov 19, 2024
Comment on lines
166
to
204
| ) | ||
| return null; | ||
| else { | ||
| if (value) { | ||
| if (value.length < 8) | ||
| return 'パスワードは8文字以上で入力してください'; | ||
| else if (/^(?=.*[A-Za-z])(?=.*\d)[A-Za-z\d]+$/.test(value)) | ||
| return null; | ||
| else return 'パスワードにはアルファベットと数字を含めてください'; | ||
| } else return '現在のパスワードを入力してください'; | ||
| } | ||
| // パスワードフォームを触っていない | ||
| } else return null; | ||
| }, | ||
| newPassword: (value, values) => { | ||
| // パスワードを更新しようとしている | ||
| if (value || values.currentPassword || values.newPasswordAgain) { | ||
| // パスワードフォームが全て空文字列 | ||
| if ( | ||
| value === '' && | ||
| values.currentPassword === '' && | ||
| values.newPasswordAgain === '' | ||
| ) | ||
| return null; | ||
| else { | ||
| if (value) { | ||
| if (value.length < 8) | ||
| return 'パスワードは8文字以上で入力してください'; | ||
| else if (/^(?=.*[A-Za-z])(?=.*\d)[A-Za-z\d]+$/.test(value)) | ||
| if (values.currentPassword) { | ||
| if (value === values.currentPassword) | ||
| return 'パスワードが更新されていません'; | ||
| else return null; | ||
| } else return null; | ||
| else return 'パスワードにはアルファベットと数字を含めてください'; | ||
| } else return '新しいパスワードを入力してください'; | ||
| } | ||
| // パスワードフォームを触っていない | ||
| } else return null; |
Member
There was a problem hiding this comment.
ブロックにした方がいいと思った
newPasswordAgain のバリデーションも同様
| ); | ||
| } else { | ||
| if (props.newPassword !== props.newPasswordAgain) { | ||
| errorNotification('新しいパスワードが一致しません'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
確認した方法
pnpm run devを使い、ユーザー情報を更新して確認したスクリーンショット
自動生成したコード