削除するボタンを押した時に確認用のダイアログを表示する #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- frontend/app/routes/home.global.books.$isbn/route.tsx: Evaluated as low risk
Comments skipped due to low confidence (2)
frontend/app/components/book-detail/BookDetailDeleteButton.tsx:25
- The button text 'キャンセル' should be consistent with the rest of the application. Consider changing it to 'Cancel'.
キャンセル
frontend/app/components/book-detail/BookDetailDeleteButton.tsx:49
- The button text '削除' should be consistent with the rest of the application. Consider changing it to 'Delete'.
削除
kimurash
changed the title
Member
Author
|
|
Kosei805
approved these changes
Nov 23, 2024
| - [x] ユーザー一覧 | ||
| - [x] ユーザー追加 | ||
| - [x] ユーザー編集 | ||
| - [x] ユーザー削除 |
| 削除 | ||
| </Button> | ||
| <> | ||
| <Modal |
Contributor
There was a problem hiding this comment.
個人的にはBookDetailDeleteButtonのファイルではなく、Modelは別コンポーネントとしてファイルにすべきかと思う。
| justify="center" | ||
| gap="md" | ||
| <> | ||
| <Modal |
| 削除 | ||
| </Button> | ||
| <> | ||
| <Modal |
| id: loan.books.id, | ||
| stock: loan.loans.volume, | ||
| thumbnail: loan.books.thumbnail, | ||
| ...loan.books, |
Contributor
There was a problem hiding this comment.
これはstock=現在借りている本やから、stock=loan.volumeにしてるねん
このままやとstockが本の在庫数ならんか？
stockってカードのヘッダーの最大値って認識です
kimurash
force-pushed
the
147-destroy-dialog
branch
from
3c1c146 to
f6598f4
Compare
kimurash
force-pushed
the
147-destroy-dialog
branch
from
f6598f4 to
2cf4055
Compare
Contributor
|
LGTMです |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
イシューとは関係ない変更
確認した方法
スクリーンショット
自動生成したコード
なし