Skip to content

Conversation

@kimurash
Copy link
Member

@kimurash kimurash commented Dec 4, 2024

やったこと

  • OpenAPI の仕様を変更した 5679d0b
  • API の実装を変更した 25c1798
  • html-react-parser で本の説明をパースした d0ac11c
  • ISBN が存在する書籍を追加できるようにした
  • 出版日の日付形式を取り払った 32ddc5b
  • グローバル検索の詳細ページのURLを変更した 6284f8d

確認した方法

  • Thunder Client
  • pnpm run test

@kimurash kimurash added the backend backend development label Dec 4, 2024
@kimurash kimurash requested review from Kosei805 and Copilot December 4, 2024 23:37
@kimurash kimurash self-assigned this Dec 4, 2024
@kimurash kimurash changed the title 書籍検索のAPIを書籍のAPIから切り離した 書籍検索のAPIを変更した Dec 4, 2024
@kimurash kimurash changed the title 書籍検索のAPIを変更した グローバル検索のAPIを変更した Dec 4, 2024
@kimurash kimurash marked this pull request as draft December 4, 2024 23:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 23 changed files in this pull request and generated 1 suggestion.

Files not reviewed (15)
  • api/bundle.yml: Language not supported
  • api/openapi.yml: Language not supported
  • api/components/examples/google-book.yml: Evaluated as low risk
  • frontend/test/mocks/model/index.ts: Evaluated as low risk
  • frontend/test/mocks/model/googleBook.ts: Evaluated as low risk
  • frontend/client/client.ts: Evaluated as low risk
  • api/components/examples/book.yml: Evaluated as low risk
  • backend/src/api/book.ts: Evaluated as low risk
  • api/paths/book.yml: Evaluated as low risk
  • backend/src/api/user.ts: Evaluated as low risk
  • backend/src/index.ts: Evaluated as low risk
  • backend/test/api/books.test.ts: Evaluated as low risk
  • backend/src/schema.ts: Evaluated as low risk
  • frontend/client/client.schemas.ts: Evaluated as low risk
  • backend/src/api/google-books.ts: Evaluated as low risk
Comments skipped due to low confidence (1)

frontend/test/mocks/model/getGoogleBook200.ts:8

  • [nitpick] The type name 'GetGoogleBook200' might be inconsistent with other similar types in the codebase. Consider renaming it to 'GoogleBookResponse' for consistency.
export type GetGoogleBook200 = {

@kimurash kimurash added the frontend frontend development label Dec 5, 2024
@kimurash kimurash marked this pull request as ready for review December 5, 2024 07:35
@kimurash kimurash merged commit cd56efd into main Dec 16, 2024
3 checks passed
@kimurash kimurash deleted the 168-google-books-api branch December 16, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend backend development frontend frontend development

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

グローバル検索APIの変更

2 participants