-
Notifications
You must be signed in to change notification settings - Fork 0
グローバル検索のAPIを変更した #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
グローバル検索のAPIを変更した #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 23 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- api/bundle.yml: Language not supported
- api/openapi.yml: Language not supported
- api/components/examples/google-book.yml: Evaluated as low risk
- frontend/test/mocks/model/index.ts: Evaluated as low risk
- frontend/test/mocks/model/googleBook.ts: Evaluated as low risk
- frontend/client/client.ts: Evaluated as low risk
- api/components/examples/book.yml: Evaluated as low risk
- backend/src/api/book.ts: Evaluated as low risk
- api/paths/book.yml: Evaluated as low risk
- backend/src/api/user.ts: Evaluated as low risk
- backend/src/index.ts: Evaluated as low risk
- backend/test/api/books.test.ts: Evaluated as low risk
- backend/src/schema.ts: Evaluated as low risk
- frontend/client/client.schemas.ts: Evaluated as low risk
- backend/src/api/google-books.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
frontend/test/mocks/model/getGoogleBook200.ts:8
- [nitpick] The type name 'GetGoogleBook200' might be inconsistent with other similar types in the codebase. Consider renaming it to 'GoogleBookResponse' for consistency.
export type GetGoogleBook200 = {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
html-react-parserで本の説明をパースした d0ac11c確認した方法
pnpm run test