Skip to content

Conversation

@kimurash
Copy link
Member

@kimurash kimurash commented Dec 12, 2024

やったこと

  • react-zxing をインストールした 2950c95
  • バーコードを読み取るモーダルを実装した f14fb76
  • 蔵書一覧ページにモーダルを開くボタンを追加した 8ae282c
  • グローバル検索ページにモーダルを開くボタンを追加した 6abdb95

確認した方法

pnpm run dev

スクリーンショット

蔵書一覧ページ

@kimurash kimurash added enhancement New feature or request frontend frontend development labels Dec 12, 2024
@kimurash kimurash requested a review from Copilot December 12, 2024 02:15
@kimurash kimurash self-assigned this Dec 12, 2024
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • frontend/package.json: Language not supported
  • frontend/app/components/common/isbn-scan-modal/BarcodeScanner.tsx: Evaluated as low risk
  • frontend/app/components/common/isbn-scan-modal/IsbnScanModal.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)

frontend/app/routes/home._index/route.tsx:145

  • The eslint-disable comment is unnecessary and should be removed.
// eslint-disable-next-line @typescript-eslint/no-unused-vars

@kimurash kimurash marked this pull request as ready for review December 14, 2024 04:20
@kimurash kimurash merged commit d316f4c into main Dec 16, 2024
3 checks passed
@kimurash kimurash deleted the 46-scan-jan-cord branch December 16, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend frontend development

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

JANコードからISBNを読み取れるようにする

2 participants