improve zio config support for Map where key is a String WrappedType#413
Open
loathwine wants to merge 1 commit intokitlangton:mainfrom
Open
improve zio config support for Map where key is a String WrappedType#413loathwine wants to merge 1 commit intokitlangton:mainfrom
loathwine wants to merge 1 commit intokitlangton:mainfrom
Conversation
Author
|
Related zio-config#1381 |
Author
|
Created PR zio-config#1658. It is arguably a better fix. Then neotype would just need to derive Should I close this PR or leave it open? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
DeriveConfiginstances forMap[B, V]whereBis a newtype or subtype wrappingString.Problem
Previously, if you had a newtype key for a
Mapin your config, derivation would fail:Even though
DeriveConfig[Map[String, V]]exists, there was no way to deriveDeriveConfig[Map[UserId, V]].Solution
Two new given instances in
ZioConfigInstances:These also compose for stacked types like
Newtype[ValidatedSubtype].