Open
Conversation
Open
|
Dude pull it. :P |
|
@kitsook Pull it 👍 |
|
@kitsook pull it pls. |
|
@kitsook you still forgot to pull this. :D |
|
@kitsook are you there?! |
|
lmao I think pulling this will take longer than the popular airport in Berlin, Germany. 😆 |
|
Hello? When will this get pulled? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the version I was talking about.
What I did:
I've also deleted the test class, as I couldn't test my implementation, because I haven't got the libs used in it. You might keep your file when merging.
I compared the encryption results with 2 other chacha implementations, one in js and one in python, all three got the same results, so I hope it's correct. ^^