Skip to content

Add pre-commit configuration and use it in CI#100

Merged
timokau merged 2 commits intokiudee:masterfrom
timokau:pre-commit
Mar 21, 2020
Merged

Add pre-commit configuration and use it in CI#100
timokau merged 2 commits intokiudee:masterfrom
timokau:pre-commit

Conversation

@timokau
Copy link
Copy Markdown
Collaborator

@timokau timokau commented Mar 20, 2020

Description

Run black pre-commit and on CI.

Motivation and Context

As a follow up to #78, we should run black locally pre-commit and verify that this was done on CI. Otherwise the formatting would slowly shift away from the black standard again.

How Has This Been Tested?

By creating this PR.

Does this close/impact existing issues?

#78

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@timokau
Copy link
Copy Markdown
Collaborator Author

timokau commented Mar 20, 2020

Looks like this is working. A disadvantage is that the pre-commit hook is run 4 times, once for each listed environment. The same issue already exists with the docbuild though, where it is probably more relevant (running black is fast enough). This brings us back to #66 -- we probably should figure out a better way to parallelize the tests long-term.

But for now I think this is ready for review.

@timokau timokau changed the title Pre commit Add pre-commit configuration and use it in CI Mar 20, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 20, 2020

Pull Request Test Coverage Report for Build 742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-9.05%) to 49.786%

Totals Coverage Status
Change from base Build 740: -9.05%
Covered Lines: 3719
Relevant Lines: 7470

💛 - Coveralls

@timokau timokau merged commit 5b08c8b into kiudee:master Mar 21, 2020
@timokau timokau deleted the pre-commit branch March 21, 2020 15:19
@timokau timokau mentioned this pull request Mar 21, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants