Add pre-commit configuration and use it in CI#100
Merged
timokau merged 2 commits intokiudee:masterfrom Mar 21, 2020
Merged
Conversation
Collaborator
Author
|
Looks like this is working. A disadvantage is that the pre-commit hook is run 4 times, once for each listed environment. The same issue already exists with the docbuild though, where it is probably more relevant (running black is fast enough). This brings us back to #66 -- we probably should figure out a better way to parallelize the tests long-term. But for now I think this is ready for review. |
kiudee
approved these changes
Mar 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run
blackpre-commit and on CI.Motivation and Context
As a follow up to #78, we should run
blacklocally pre-commit and verify that this was done on CI. Otherwise the formatting would slowly shift away from the black standard again.How Has This Been Tested?
By creating this PR.
Does this close/impact existing issues?
#78
Types of changes
Checklist: