-
Notifications
You must be signed in to change notification settings - Fork 2k
GitHub Actions: Add Python 3.12, 3.13, and 3.14 to the testing #3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks, I'll merge after the next release as we will probably drop Python 3.8
Why test after making a release? Usually, tests are added before making a release. |
In this PR you dropped 3.8 which is a good thing, but that means we officially drop the support for it (which we want to). |
Please let me know if we should bring Py38 back in. |
Nope it's perfect keep it this way, I want to make a release in the coming weeks |
The reason stated for sitting on this was that it remove the EOL Python 3.8 so let's put it back is so that we are running tests on Python 3.8 plus all currently supported versions of CPython. |
Coming up on one year... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well build is green, why not.
Will leave it there for a few days and merge if nobody has anything against it.
Yeah build make take longer, but we should remove 3.8 at some point eventually
3.9 will go EOL in a few weeks so I doubt there will be serious protest about dropping support for 3.8. |
Uh oh!
There was an error while loading. Please reload this page.