김정교 3번째 PR입니다. #12
Open
김정교 3번째 PR입니다. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deocksoo
requested changes
Jan 11, 2020
| public class Car { | ||
|
|
||
| private static final double GO_FLOOR = 0.4; | ||
| private static final double GO_THRESHOLD = 0.4; |
| winnerList.add("a"); | ||
| winnerList.add("b"); | ||
| winnerList.add("c"); | ||
| winnerList.equals(racingCarGamePlay.getWinner(racingCarGamePlay.makeCars(targetCarNames))); |
src/test/java/RacingCarGameTest.java
Outdated
| String[] targetCarNames = {"a", "b", "c"}; | ||
| String testString = "a,b,c"; | ||
| String[] splitedCarNames = RacingCarGame.makeCarNames(testString); | ||
| assertEquals(true, Arrays.equals(splitedCarNames,targetCarNames)); |
There was a problem hiding this comment.
makeCarNames에서 배열 대신 collection을 리턴하면 이 부분도 조금 더 간결해질 수 있을거같아요.
| @Test | ||
| void testGetWinner() { | ||
| String[] targetCarNames = {"a", "b", "c"}; | ||
| RacingCarGamePlay racingCarGamePlay = new RacingCarGamePlay(targetCarNames, 0); |
There was a problem hiding this comment.
테스트에서도 하드코딩된 숫자를 추출하면 더 쉽게 읽을 수 있을것 같아요 :)
Contributor
Author
|
re-request review 버튼이 안보여용 ㅠ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TDD로 다시 짜는 것을 하지 못하고 단위테스트 몇 개를 붙이는데 멈추고 말았습니다...