5주차 팀, 역할 추가 및 Service, Repository 테스트 추가 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Feature/#1/문서, 사용자 도메인 구현
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Signed-off-by: Beenie93 <seongbeen93@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 재주 선생님!
5주차 리뷰 부탁드립니다 :)
Controller 테스트는 기존과 같이 상태코드로만 검증하게 작성하였으며 추후 Controller 테스트 요구사항 맞춰 리팩토링하도록 하겠습니다!
Service 테스트는 제가 기존에 하던 Mockito를 사용하여 단위테스트 방식으로 구현하였는데 연관관계가 많아지고 복잡해질수록 너무 코드가 지저분해진다는 것을 다시 한번 느꼈습니다ㅠㅠ
이 부분은 다음 주차 과제하면서 우빈님이 말씀해주신 방식대로 통합테스트로 변경하겠습니다!
그 외에도 미흡한 부분 말씀해주시면 보완하도록 하겠습니다!