Skip to content

Added popen_args parameter to run_async() #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelitvin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added popen_args parameter to run_async() #675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ffmpeg/_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ def run_async(
quiet=False,
overwrite_output=False,
cwd=None,
popen_args=None,
):
"""Asynchronously invoke ffmpeg for the supplied node graph.

Expand All @@ -213,6 +214,7 @@ def run_async(
pipe_stderr: if True, connect pipe to subprocess stderr.
quiet: shorthand for setting ``capture_stdout`` and
``capture_stderr``.
popen_args: A dictionary of keyword arguments passed to Popen().
**kwargs: keyword-arguments passed to ``get_args()`` (e.g.
``overwrite_output=True``).

Expand Down Expand Up @@ -284,6 +286,10 @@ def run_async(
stdin_stream = subprocess.PIPE if pipe_stdin else None
stdout_stream = subprocess.PIPE if pipe_stdout else None
stderr_stream = subprocess.PIPE if pipe_stderr else None

if popen_args is None:
popen_args = {}

if quiet:
stderr_stream = subprocess.STDOUT
stdout_stream = subprocess.DEVNULL
Expand All @@ -293,6 +299,7 @@ def run_async(
stdout=stdout_stream,
stderr=stderr_stream,
cwd=cwd,
**popen_args
)


Expand Down