set first bit of EESP packet before to 1 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonyantony
force-pushed
the
antony/edit-7-version-4-bits
branch
from
08e76f8 to
078fae0
Compare
This change helps distinguish EESP from ESP on a receiver when using UDP encapsulation. It allows having both EESP and ESP SAs on the same receiver. For ESP, SPI should start with 0. On Linux, when allocating SPI, i.e. calling XFRM_MSG_ALLOCSPI: - struct xfrm_userspi_info->min = 0 - struct xfrm_userspi_info->max = 2^31 max value = (INT32_MAX - 1) = (2^31 - 1) = 2147483647
antonyantony
force-pushed
the
antony/edit-7-version-4-bits
branch
from
078fae0 to
caedfba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps distinguish EESP from ESP on a receiver when using UDP encapsulation. It allows having both EESP and ESP SAs on the same receiver.
For ESP, SPI should start with 0. On Linux, when allocating SPI, i.e. calling XFRM_MSG_ALLOCSPI:
max value = (INT32_MAX - 1) = (2^31 - 1) = 2147483647