Open
Conversation
added 3 commits
December 8, 2015 10:23
Rather than using the `getFilepath`'d filename, get the extensions of the original path, and pass it into the transform constructor.
Author
|
Oops my bad, it seems my changes would be breaking to the api, making this more of a 4.0.0. I'll have to rethink how to handle this situation. Suggestions are welcome of course! |
There was a problem hiding this comment.
Don’t bump package version. This is module owners job.
Member
|
For me a breaking change is not a big deal, I'm working on another small breaking change anyway. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than using the
getFilepath'd filename to get the extension, I use the original path and pass the extension directly into the transform constructor.