Option to allow single tag (no end tag)#279
Open
specious wants to merge 4 commits intoklei:masterfrom
Open
Conversation
Author
|
This branch can be used right way with {
"devDependencies": {
"gulp-inject": "klei/gulp-inject#741048f"
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joakimbeng, I'd like to extend to you my appreciation for writing this gulp plug-in.
I've got a project that uses gulp-inject, which injects CSS and JS contents into the HTML. I realized it would be nice to be able to omit the closing tag, to just have placeholders like this:
This pull requests adds an option named
singleTagwhich, if set totrue, will no longer require a matching end tag.If you would kindly take a look at this and consider merging it, I would love to switch to using a newer published version of gulp-inject with the ability to do this.
Also, if you don't mind, I might also like to contribute some refactoring improvements which could make it easier for people to make further contributions to this project.